Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect api visibility for oneof enum #15122

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Respect api visibility for oneof enum #15122

merged 1 commit into from
Apr 4, 2023

Conversation

tbarbugli
Copy link
Contributor

Swift5 generator does not take into account of the --additional-properties=nonPublicApi=true param when generating oneOf models (enums). @4brunu @jaz-ah @Edubits

This PR adds the same check present in other templates to add public or internal keyword

4brunu
4brunu approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@4brunu 4brunu merged commit b409ceb into OpenAPITools:master Apr 4, 2023
@wing328 wing328 added this to the 6.6.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4brunu 4brunu 4brunu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tbarbugli @4brunu @wing328